Separate B2C logic from AAD v2 #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldalton
requested review from
antrix1989,
unpluggedk,
jasoncoolmax and
rohitnarula7176
unpluggedk
reviewed
Oct 24, 2018
| return NO; | ||
| } | ||
|
|
||
| BOOL result = [super fillAccount:account fromResponse:response configuration:configuration]; |
There was a problem hiding this comment.
Let's do a separate follow up, I'd like to see this method return an account instead of it touching the passed in one.
There was a problem hiding this comment.
Sure, added on issue here: #269
unpluggedk
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're applying more and more B2C specific fixes (e.g. fallback logic when tenantId is not present in the id_token), I separated B2C specific token creation logic, which derives from AAD v2.
This also fixes B2C access token lookups when tenantId not returned in the id_token.