-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix project - integrate fixed MSID #283
Conversation
MSAL/src/MSALErrorConverter.m
Outdated
@@ -64,6 +64,7 @@ + (void)initialize | |||
@(MSIDErrorInvalidRequest) :@(MSALErrorInvalidRequest), | |||
@(MSIDErrorInvalidClient) : @(MSALErrorInvalidClient), | |||
@(MSIDErrorInvalidGrant) : @(MSALErrorInvalidParameter), | |||
@(MSIDErrorInvalidScope) : @(MSALErrorInvalidParameter), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have an MSAL error to return invalid scope? same for invalid grant :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nit questions
MSAL/src/MSALErrorConverter.m
Outdated
@(MSIDErrorServerOauth) : @(MSALErrorAuthorizationFailed), | ||
@(MSIDErrorServerInvalidResponse) : @(MSALErrorInvalidResponse), | ||
@(MSIDErrorServerRefreshTokenRejected) : @(MSALErrorAuthorizationFailed), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a better corresponding error code than MSALErrorAuthorizationFailed (which sounds more like interactive error)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added corresponding error for msal. also filed an issue to improve refactoring #285
MSAL/src/MSALErrorConverter.m
Outdated
@(MSIDErrorServerInvalidGrant) : @(MSALErrorInvalidGrant), | ||
@(MSIDErrorServerInvalidScope) : @(MSALErrorInvalidScope), | ||
@(MSIDErrorServerInvalidState) : @(MSALErrorInvalidState), | ||
@(MSIDErrorServerNonHttpsRedirect) : @(MSALErrorInternal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we have a corresponding MSAL error? If not, let's add it, as it sounds important to call out this specific reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added corresponding error for msal. also filed an issue to improve refactoring #285
MSAL/src/MSALErrorConverter.m
Outdated
// Interactive flow | ||
@(MSIDErrorAuthorizationFailed) : @(MSALErrorAuthorizationFailed), | ||
@(MSIDErrorUserCancel) : @(MSALErrorUserCanceled), | ||
@(MSIDErrorSessionCanceledProgramatically) : @(MSALErrorSessionCanceled), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: MSIDErrorSessionCanceledProgramatically should have double "m"
Project file was broken, now it is fixed.
AzureAD/microsoft-authentication-library-common-for-objc#155
update after error code PR AzureAD/microsoft-authentication-library-common-for-objc#153