Add API and make ROPC call #3103
Draft
+124
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmprieur
reviewed
Oct 24, 2024
src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisition.cs
Outdated
Show resolved
Hide resolved
| string username = user.FindFirst(ClaimConstants.Username)?.Value ?? string.Empty; | ||
| string password = user.FindFirst(ClaimConstants.Password)?.Value ?? string.Empty; | ||
|
|
||
| var accounts = await application.GetAccountsAsync().ConfigureAwait(false); |
There was a problem hiding this comment.
I don't think that this exists in confidential client applications? does it?
or does it only contain the ROPC accounts?
We need to be very careful here.
There was a problem hiding this comment.
It exists in confidential client applications. It is currently obsolete but we still use in MSAL tests. I have created this PR in MSAL.Net to remove the obsolete attribute from this method as suggested by @bgavrilMS
There was a problem hiding this comment.
Wow. I need explanations here.
- which account will they return be in a web app that signs-in users?
There was a problem hiding this comment.
Agree that this seems to be going backwards.
SummarySummary
CoverageMicrosoft.Identity.Web - 63.4%
Microsoft.Identity.Web.Certificate - 41.4%
Microsoft.Identity.Web.Certificateless - 40.1%
Microsoft.Identity.Web.Diagnostics - 10.2%
Microsoft.Identity.Web.DownstreamApi - 14.5%
Microsoft.Identity.Web.MicrosoftGraph - 42%
Microsoft.Identity.Web.Test.Common - 69.3%
Microsoft.Identity.Web.TokenAcquisition - 52.2%
Microsoft.Identity.Web.TokenCache - 80.8%
|
SummarySummary
CoverageMicrosoft.Identity.Web - 63.4%
Microsoft.Identity.Web.Certificate - 41.4%
Microsoft.Identity.Web.Certificateless - 40.1%
Microsoft.Identity.Web.Diagnostics - 10.2%
Microsoft.Identity.Web.DownstreamApi - 14.5%
Microsoft.Identity.Web.MicrosoftGraph - 42%
Microsoft.Identity.Web.Test.Common - 69.3%
Microsoft.Identity.Web.TokenAcquisition - 52.2%
Microsoft.Identity.Web.TokenCache - 80.8%
|
jennyf19
reviewed
Oct 28, 2024
| /// <summary> | ||
| /// Username claims for ROPC flow. | ||
| /// </summary> | ||
| public const string Username = "xms-username"; |
There was a problem hiding this comment.
Please resolve the warnings in the GitHub Actions. You can see them in the UI via GitHub, or in the IDE In VS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement ROPC flow
Summary of the changes (Less than 80 chars)
Add ROPC flow to use username and password and call MSAL using the credentials
Description
{Detail}
Fixes #3091