Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggesting runtime tests #126

Open
smoe opened this issue Mar 31, 2022 · 4 comments
Open

suggesting runtime tests #126

smoe opened this issue Mar 31, 2022 · 4 comments

Comments

@smoe
Copy link
Contributor

smoe commented Mar 31, 2022

There should be some prior art on this somewhere on the Internet - https://www.nist.gov/programs-projects/genome-bottle comes to mind. But that is already about semantics. I thought it would possibly help if we ran pigx-rnaseq on very a small example project for a technical validation. Would you be open for that? I am tempted to suggest to avoid anything human (because of the personal data issue) and take something that geneticists have a good understanding for, like worm or drosophila, and a fragment of reads and the genome would suffice.

@borauyar
Copy link
Member

borauyar commented Apr 1, 2022

I don't know what would be the technical validation for. Is it for testing the pipeline on a real use case for releases? I run it on real datasets every time I make a release. We also tested this on real use case in the pigx paper, showing that we could reproduce the results in the original paper where the data was published.

@smoe
Copy link
Contributor Author

smoe commented Apr 1, 2022

After preparing a small patch you may want to run the pipeline quickly to learn how this affects the reports. Also, among developers you want to make sure that everyone looks at the same kind of input. My hope is that this also helps with the reporting of errors.

@rekado
Copy link
Member

rekado commented Apr 1, 2022

is the existing test infrastructure (run with make check) not enough? Each of these tests runs the pipeline (or parts of it) on test data. For new features it is always good to have matching tests that demonstrate and validate them.

@smoe
Copy link
Contributor Author

smoe commented Apr 1, 2022

I need a bit of time to cross-check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants