Skip to content

Commit

Permalink
v8 without inspector (#1278)
Browse files Browse the repository at this point in the history
Fix v8 without inspector installation

also needs this BabylonJS/JsRuntimeHost#46
  • Loading branch information
CedricGuillemet authored Aug 8, 2023
1 parent 923fa6d commit 899a060
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ FetchContent_Declare(ios-cmake
GIT_TAG 04d91f6675dabb3c97df346a32f6184b0a7ef845)
FetchContent_Declare(JsRuntimeHost
GIT_REPOSITORY https://github.com/BabylonJS/JsRuntimeHost.git
GIT_TAG 1ff3a500b98264c15a08f6aca9baee0e662d3eaf)
GIT_TAG 85d8d91be3c157bf61857c1e1346444024794142)
FetchContent_Declare(AndroidExtensions
GIT_REPOSITORY https://github.com/BabylonJS/AndroidExtensions.git
GIT_TAG 883c4a286116e51ee989e39ee8e216d632997329)
Expand Down
2 changes: 1 addition & 1 deletion Install/Install.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ endif()

install_targets(napi)

if(NAPI_JAVASCRIPT_ENGINE STREQUAL "V8")
if(NAPI_JAVASCRIPT_ENGINE STREQUAL "V8" AND JSRUNTIMEHOST_CORE_APPRUNTIME_V8_INSPECTOR)
install_targets(v8inspector)
endif()

Expand Down

0 comments on commit 899a060

Please sign in to comment.