iOS AR Metal Validation Error #1403
Draft
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantrem
reviewed
Jul 17, 2024
| @@ -946,6 +946,8 @@ void UpdateXRView(MTKView* activeXRView) { | |||
|
|
|||
| // Finalize rendering here & push the command buffer to the GPU. | |||
| [currentCommandBuffer commit]; | |||
|
|
|||
| [currentCommandBuffer waitUntilCompleted]; | |||
There was a problem hiding this comment.
What validation error does this fix? I don't think this is good for perf. I think we used to do this and tried to get rid of it, because it blocks this thread until the command buffer has been executed by the gpu.
There was a problem hiding this comment.
I know but I'd like to narrow down the issue to see if it's this command buffer that's causing all the crashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up https://forum.babylonjs.com/t/babylonnative-ios-ar-crash/51876/19