Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix permissions after basekit changes #606

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

CedricGuillemet
Copy link
Contributor

Fix the regressions appearing after #598
An error with RNPermissionsModule not found.
I've reverted the change in the json and everything is fine again.
Why is dependency needed in react-native package as it's already present in other packages like

?
Can this be an issue for basekit package ? @nima-ap

@ryantrem
Copy link
Member

Strange. I think this must be the rn permissions js code is looking for a file by relative path or something. This probably doesn't repro with the published packages, it's probably a side effect of the local packages used within the BRN repository. That said, I also doubt this reference will cause a problem for those who are trying to avoid using native APIs that require permissions.

@CedricGuillemet CedricGuillemet merged commit 17a850c into BabylonJS:master Sep 27, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants