Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added function to simplify to 2 journey levels #153

Merged
merged 9 commits into from
Jul 30, 2024
Merged

Added function to simplify to 2 journey levels #153

merged 9 commits into from
Jul 30, 2024

Conversation

vivverma9
Copy link
Collaborator

What existing problem does the pull request solve and why should we include it?

  • It simplifies the faresystem grouping/journey levels to only 2 for runtime reduction of transit assignment.

What is the testing plan?

  • Testing has been done. Runtime reduction of upto 75% on AM assignment achieved.

Issues List

@vivverma9
Added function to simplify to 2 journey levels
47ee90d 
group_faresystems_simplified() creates two faresytem groups: Muni (25) vs others
@vivverma9 vivverma9 linked an issue Jun 24, 2024 that may be closed by this pull request
🚀 Feature: Reduce Number Transit Journey Levels -- Phase 1 #145
Closed
8 tasks
@i-am-sijia i-am-sijia mentioned this pull request Jul 9, 2024
Open
7 tasks
DavidOry
DavidOry reviewed Jul 17, 2024
View reviewed changes
tm2py/config.py Outdated Show resolved Hide resolved
DavidOry
DavidOry reviewed Jul 17, 2024
View reviewed changes
tm2py/config.py Outdated Show resolved Hide resolved
DavidOry
DavidOry reviewed Jul 17, 2024
View reviewed changes
tm2py/config.py Outdated Show resolved Hide resolved
@i-am-sijia i-am-sijia merged commit c1ac021 into develop Jul 30, 2024
0 of 2 checks passed
@i-am-sijia i-am-sijia deleted the transit_journey_level_simplification branch July 30, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidOry DavidOry DavidOry left review comments

@lmz lmz Awaiting requested review from lmz lmz is a code owner

@FlaviaTsang FlaviaTsang Awaiting requested review from FlaviaTsang FlaviaTsang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
EMME/ActivitySim Conversion Task Order #5
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Reduce Number Transit Journey Levels -- Phase 1
3 participants
@vivverma9 @DavidOry @i-am-sijia