Add support for Windows #45
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires changing a few implementation details: - Now fully resolve the command before launching it within the venv, otherwise, in some obscure cases, Windows would not find the executable - Add more environment variables as passthrough, they are hard requirement in order to be able to run on windows - Also add some missing PKG_CONFIG variables as we are reworking this area
…pport for Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires changing a few implementation details:
fix #36
The current problems are:
unimporttests with encoding errors_subprocmodule fails pylint checks on Windows, it uses apis that are not available there