Fix undefined names and add ruff F821 pre-commit check - #500
Open
Souravrajvi0 wants to merge 2 commits into
Open
Fix undefined names and add ruff F821 pre-commit check#500Souravrajvi0 wants to merge 2 commits into
Souravrajvi0 wants to merge 2 commits into
Conversation
Resolve 15 pyflakes F821 findings across src/scenic, including three runtime NameErrors in OperatorDistribution.evaluateInner, Vector.cross, and PolygonalFootprintRegion.containsRegionInner. Add a ruff-check hook scoped to src/ with --select F821 and --target-version py311, plus regression tests for the three bugs.
Souravrajvi0
marked this pull request as draft
August 28, 2026 15:59
Souravrajvi0
marked this pull request as ready for review
August 28, 2026 16:26
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix undefined names in src/scenic and add ruff F821 pre-commit check (#493).
Issue Link
Fixes #493
Checklist
pytestand/or other meansAdditional Notes
N/A