Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): commas in selected categories messge bb-340 #616

Open
wants to merge 274 commits into
base: main
Choose a base branch
from

Conversation

ihorLysak
Copy link
Collaborator

Summary

Added behaviour described by @luiqor in this message on slack

AndriiLevin and others added 30 commits September 9, 2024 22:23
fshabanov and others added 20 commits September 25, 2024 10:53
for (const category of newSelectedCategories) {
namesOfSelectedCategories += `${category.name}\n`;
}
let namesOfSelectedCategories = newSelectedCategories
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let namesOfSelectedCategories = newSelectedCategories
const namesOfSelectedCategories = newSelectedCategories

})
.addCase(getTasksForCategories.rejected, (state) => {
state.dataStatus = DataStatus.REJECTED;
state.buttonsMode = ButtonsModeOption.SUGGESTIONS_MANIPULATION;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was rejected state removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants