Fixed useUnsetCursorPositionOnBlur not hiding cursors. #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`useUnsetCursorPositionOnBlur` does not hide cursors when the remote editor blurs. This happens because `useUnsetCursorPositionOnBlur` only sets the cursor state field to `null` on blur, but does not set the client data field to `null`, which prevents the client from being deleted from the awareness state. One possible fix is to delete both fields on blur. Another possible fix (this PR) is to remove the cursor if the selection range gets deleted.
|
|
Didn't see the contributing instructions. I'll see what I can do about creating a test to reproduce this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useUnsetCursorPositionOnBlurdoes not hide cursors when the remote editor blurs. This happens becauseuseUnsetCursorPositionOnBluronly sets the cursor state field tonullon blur, but does not set the client data field tonull, which prevents the client from being deleted from the awareness state.One possible fix is to delete both fields on blur.
Another possible fix (this PR) is to remove the cursor if the selection range gets deleted.