Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: header + welcome section #114

Merged
merged 25 commits into from
Jun 14, 2024

Conversation

gabitoesmiapodo
Copy link
Collaborator

Closes #107
Closes #108

Description:

Added:

  • A simple functional main menu to the header.
  • Landing page's welcome section.
  • Updated (externally) a few things from the dAppBooster UI Toolkit (don't worry about that).

Updated:

  • Header's styles.
  • Theme variables.

Removed:

  • Styled CSS plugin (order).
  • Some unused components and sections (about page, contact page, etc.)

Chores / refactoring:

  • Moved all the general use components to the sharedComponents folder. The ui / web3 etc. divide was confusing, let's put everything there until / if we think of something better.
  • The pageComponents folder still exists for components specific to each page (this for example will allow users to remove the whole pageComponents/home folder in the future).
  • Moved (or created) some components to the pageComponents/home/examples/Items folder. Don't pay much attention to what's in there, we have to refactor this in the future when we implement the list proper. The idea here is to show users how to use what's in sharedComponents: "OK, so I want to use the Avatar / Hash / BigNumberInput component from the sharedComponents folder. What should I do? Oh, look! There's an example folder! These guys must be geniuses!" This obviously looks like crap for now. I repeat: just ignore what's in there. Or fix it in a new PR, you lazy bastards.

Notes:

  • I tried not to modify an excessive amount of files, but it was kind of impossible to implement the Header and WelcomeSection separately, so I ended up modifying more files than I wanted to. Plus there were a few PRs you guys merged that I had to deal with (and ended up in the pile of crap the examples section is right now).
  • I know that the ConnectButton component doesn't look like in the design when the user is connected. The design was not available when I implemented that, I'll update the button later.
  • dAppBooster UI Toolkit points now to the repo's main branch. I'll leave it that way until I create a properly versioned release (or release candidate).

Steps:

Look at the preview and check that everything I mentioned is in there.

Type of change:

  • New feature
  • Bug fix
  • Breaking change
  • Enhancement
  • Refactoring
  • Chore

How Has This Been Tested?

  • Manual testing
  • Automated tests
  • Other (explain)

Remember to check that:

  • Your code follows the style guidelines of this project
  • You have performed a self-review of your code
  • You have commented your code in hard-to-understand areas
  • You have made corresponding changes to the documentation
  • Your changes generate no new warnings

Screenshots

image
image

Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dappbooster ✅ Ready (Inspect) Visit Preview Jun 14, 2024 5:08pm

@gabitoesmiapodo gabitoesmiapodo self-assigned this Jun 13, 2024
Copy link
Member

@fernandomg fernandomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the type in MenuItem, nothing to add, beautiful!

label: 'Examples',
to: '/#examples',
},
] as MenuItem[]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type assertion may lead to false positives.

If there's no big issue, I would go with:

export const menuItems: MenuItems[] = [

onClick={() => setTheme(theme === 'light' ? 'dark' : 'light')}
theme={theme}
/>
<SwitchThemeButton onClick={() => setTheme(theme === 'light' ? 'dark' : 'light')} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@@ -35,7 +35,7 @@
"@tanstack/react-query": "^5.36.0",
"@tanstack/react-router": "^1.32.5",
"connectkit": "^1.7.3",
"db-ui-toolkit": "github:BootNodeDev/db-ui-toolkit#0.0.7",
"db-ui-toolkit": "github:BootNodeDev/db-ui-toolkit",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧠

@gabitoesmiapodo gabitoesmiapodo merged commit 15fc2e0 into main Jun 14, 2024
2 checks passed
@gabitoesmiapodo gabitoesmiapodo deleted the feat/#107-header-#108-welcome-section branch June 14, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Welcome section Header
2 participants