-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: header + welcome section #114
Conversation
…r landing page design Probably will regret this in the future.
# Conflicts: # src/pageComponents/home/index.tsx
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the type in MenuItem
, nothing to add, beautiful!
src/constants/menuItems.ts
Outdated
label: 'Examples', | ||
to: '/#examples', | ||
}, | ||
] as MenuItem[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type assertion may lead to false positives.
If there's no big issue, I would go with:
export const menuItems: MenuItems[] = [
onClick={() => setTheme(theme === 'light' ? 'dark' : 'light')} | ||
theme={theme} | ||
/> | ||
<SwitchThemeButton onClick={() => setTheme(theme === 'light' ? 'dark' : 'light')} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
@@ -35,7 +35,7 @@ | |||
"@tanstack/react-query": "^5.36.0", | |||
"@tanstack/react-router": "^1.32.5", | |||
"connectkit": "^1.7.3", | |||
"db-ui-toolkit": "github:BootNodeDev/db-ui-toolkit#0.0.7", | |||
"db-ui-toolkit": "github:BootNodeDev/db-ui-toolkit", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧠
Closes #107
Closes #108
Description:
Added:
Updated:
Removed:
Chores / refactoring:
sharedComponents
folder. Theui
/web3
etc. divide was confusing, let's put everything there until / if we think of something better.pageComponents
folder still exists for components specific to each page (this for example will allow users to remove the wholepageComponents/home
folder in the future).pageComponents/home/examples/Items
folder. Don't pay much attention to what's in there, we have to refactor this in the future when we implement the list proper. The idea here is to show users how to use what's insharedComponents
: "OK, so I want to use theAvatar
/Hash
/BigNumberInput
component from thesharedComponents
folder. What should I do? Oh, look! There's an example folder! These guys must be geniuses!" This obviously looks like crap for now. I repeat: just ignore what's in there. Or fix it in a new PR, you lazy bastards.Notes:
Steps:
Look at the preview and check that everything I mentioned is in there.
Type of change:
How Has This Been Tested?
Remember to check that:
Screenshots