fix(Tokens Dropdown): tokens by network and native tokens #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required updating `useTokenSearch` API, by allowing passing a dependencies array, so when chainId changes list is updated accordingly.
Also, included OP as optional network in examples
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # pnpm-lock.yaml # src/pageComponents/home/Examples/demos/TokenDropdown/index.tsx # src/pageComponents/home/Examples/demos/assets/Optimism.tsx
luchobonatti
requested changes
Jul 8, 2024
There was a problem hiding this comment.
Awesome work fer!
Just, remove the changes in the TransactionButton Component to avoid conflicts with #161
There was a problem hiding this comment.
Please, remove these changes. I fixed it in #161 .
|
I updated the dropdown with some changes from db-ui-toolkit, but LGTM. |
This reverts commit e7b3cab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32
Description:
This is PR to conclude what has been done in #150.
This mainly:
tsccode verification by usingtsc-filesto ensure only those staged files are checked in the pre-commit hook.Infinityvalue to thegcTimeparam.Balance fetch will be worked on a separate task: #156
Steps:
Check that TokenList behave as expected
Type of change:
How Has This Been Tested?
Remember to check that:
Screenshots
Screen.Recording.2024-07-08.at.11.37.22.AM.mov
Screen.Recording.2024-07-08.at.12.50.33.PM.mov