fix(release): --ignore-scripts 로 건너뛴 ripgrep·electron postinstall 복구 - #47
Merged
Conversation
v2.4.1 Windows 빌드가 SDK 스테이징까지 진행한 뒤 멈췄다. ERROR: @vscode/ripgrep not installed or postinstall did not run Run 'bun install' and 'bun pm trust @vscode/ripgrep'. `bun install --frozen-lockfile --ignore-scripts` 가 네이티브 바이너리를 받아오는 postinstall 까지 건너뛴다. build-win.ps1 은 ripgrep 바이너리를 설치파일에 복사하므로 없으면 빌드가 멈추고, electron 도 electron-log 가 로드 시점에 require 하므로 필요하다. (같은 원인으로 ci.yml 의 데스크톱 테스트가 21회 실패했고 cdb00f1 에서 고쳤다) 스크립트가 안내하는 `bun pm trust @vscode/ripgrep` 를 쓰되, no-op 인 경우를 대비해 바이너리 존재를 확인하고 없으면 패키지의 postinstall(lib/postinstall.js)을 직접 실행한다. 마지막에 test -f 로 결과를 검증해 조용한 실패를 막는다. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
릴리스 워크플로의 Windows 잡이
bun install --ignore-scripts를 쓰는데, 이는@vscode/ripgrep과electron의 postinstall(바이너리 다운로드)까지 건너뛴다. 그래서 v2.4.1 릴리스가ERROR: @vscode/ripgrep not installed or postinstall did not run으로 실패했다.CI 에는 같은 계열 수정(
cdb00f1, electron 바이너리)이 이미 들어가 있었으나 릴리스 워크플로에는 없었다.Test Plan
test -f node_modules/@vscode/ripgrep/bin/rg.exe로 산출물 존재를 워크플로 안에서 직접 검증