Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: overhaul SvelteKit guide #436

Merged
merged 4 commits into from
Aug 2, 2023
Merged

docs: overhaul SvelteKit guide #436

merged 4 commits into from
Aug 2, 2023

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Jul 6, 2023

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Changes:

  • onMount should not be used. It's called on document load. For the GA example, that's too late
  • write the scripts to SvelteKit's output directory rather than the user's source directory
  • Remove the reverse proxying example. It's extremely confusing to show a reverse proxy with for GA because it conflicts with the GTM docs, which say a reverse proxy is not necessary
  • Clarify that one step refers to svelte-preprocess, which is generally no longer used

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@vercel
Copy link

vercel bot commented Jul 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
partytown ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2023 11:12pm

@mhevery mhevery merged commit c9be0a1 into BuilderIO:main Aug 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants