renamed the parameter for cript.API.download_file from object_name to file_source
#212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because it can be both AWS S3 object_name or file URL
|
Merging to
|
nh916
added
enhancement
InnocentBug
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
before
cript.API.download_file()hadobject_nameas parameter, which made sense because it could only download files from AWS S3, but since it can work with file URLs as well then that no longer makes sense. Changed the parameter name tofile_sourceChanges
Tests
Known Issues
Notes
Checklist
CONTRIBUTORS.md) in the pull request source branch.