Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrading tests.yml #218

Merged
merged 7 commits into from
Jul 21, 2023
Merged

upgrading tests.yml #218

merged 7 commits into from
Jul 21, 2023

Conversation

nh916
Copy link
Contributor

@nh916 nh916 commented Jul 21, 2023

Description

refactoring tests.yaml

Changes

  • putting environment variables within env block
  • changing steps name to make them more obvious
  • installing requirements_dev.txt in one step and pytest is a part of requirements_dev.txt
    • requirements_dev.txt now has pytest inside of it
  • running tests with a single command
  • spacing out the steps to make it clearer and more readable
  • giving the option for tests to be ran manually if desired

Tests

tested it on a forked repository
forked repository tests action results

Known Issues

Notes

Checklist

  • My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.
  • I have updated the documentation to reflect my changes.

* putting environment variables within `env` block
* changing steps name to make them more obvious
* installing `requirements_dev.txt` in one step and pytest is a part of `requirements_dev.txt`
* running tests with a single command
* spacing out the steps to make it clearer and more readable
@trunk-io
Copy link

trunk-io bot commented Jul 21, 2023

Merging to develop in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@nh916
Copy link
Contributor Author

nh916 commented Jul 21, 2023

depends on this PR because it requirements_dev.txt needs to have pytest as a requirement package

#210

putting the spaces back as they were not the issue
with python3 -m pip install it will no longer use python2 by default
@nh916 nh916 marked this pull request as ready for review July 21, 2023 19:06
@nh916 nh916 requested a review from InnocentBug July 21, 2023 19:06
@nh916 nh916 merged commit f2f9f70 into develop Jul 21, 2023
14 checks passed
@nh916 nh916 deleted the upgrade_tests_ci branch July 21, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants