Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Importing Fixtures Automatically into conftest.py #219

Merged
merged 4 commits into from
Jul 21, 2023

Conversation

nh916
Copy link
Contributor

@nh916 nh916 commented Jul 21, 2023

Description

import all fixtures in primary, subobject, and supporting nodes. This way it is imported automatically instead of being imported one at a time and if we make a new fixture, we don't have to remember to import it into conftest.py, as it will automatically get imported in

Changes

  • importing fixtures in with wildcard instead of one at a time

Tests

  • tested a few nodes to be sure there is no fixture or path error and they worked fine

Known Issues

Notes

Checklist

  • My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.
  • I have updated the documentation to reflect my changes.

this way it is imported automatically instead of being imported one at a time and if we make a new fixture, we don't have to remember to import it into conftest.py, as it will automatically get imported in
@trunk-io
Copy link

trunk-io bot commented Jul 21, 2023

Merging to develop in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@nh916 nh916 requested a review from InnocentBug July 21, 2023 20:32
Copy link
Collaborator

@InnocentBug InnocentBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a superfan of wild card imports, but it works I guess.

@nh916 nh916 merged commit 0a47453 into develop Jul 21, 2023
14 checks passed
@nh916 nh916 deleted the fixture_import_cleanup branch July 21, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants