Knocking out TODO comments where possible
#220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging to
|
instead of checking if the db schema is the exact same, I am checking if it has more than 30 fields db schema is always changing so this test will break often, but it should have more than 30 fields because there are at least 24 nodes
* added docstrings * made instantiation into named arguements * changed tha variable name from `p` to `my_property` * still functions exactly the same
* `complex_algorithm_node` was actually minimalistic with only required arguments instead of all arguments * all tests are passing as before
* avoiding `deep_copy` as that causes issues * using simple fixtures * to avoid deep_copy and to make working with a huge node easier * using fixtures instead of remaking nodes * `complex_process` fixture is not being used in any tests
* removed unneeded comment
simple_process_node does not need deep_copy within the fixture as is more straight forward and all tests work fine without it and
InnocentBug
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Knocked out a few small TODO that was left. Not a huge improvement to the project, but helps knock out some things that we've been putting aside
Changes
pytest.skip30fieldscomplex_algorithm_nodetosimple_algorithm_nodesimple_property_nodefixture to named arguments, and added docstrings to itdeep_copyas that causes issuessimple_process_nodedoes not need deep_copy within the fixture as is more straight forward and all tests work fine without it andTests
Known Issues
Notes
Checklist
CONTRIBUTORS.md) in the pull request source branch.