wrote test function for _is_node_field_valid()
#224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrote test function and test cases for `_is_node_field_valid`
|
Merging to
|
nh916
changed the title
_is_node_field_valid_is_node_field_valid()
|
@InnocentBug I was thinking of wrapping the function with a |
InnocentBug
approved these changes
Jul 26, 2023
|
this is excellent |
Thank you so much! If you can think of more test cases feel free to add them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this function was missing a test case and since I am thinking of refactoring it soon, test cases would be really helpful with that and being sure that the project works well anyways
Changes
_is_node_field_valid()Tests
Known Issues
Notes
Checklist
CONTRIBUTORS.md) in the pull request source branch.