Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed extra duplicate step at the end #229

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

nh916
Copy link
Contributor

@nh916 nh916 commented Jul 26, 2023

Description

removed extra duplicate step at the end

Changes

Tests

Known Issues

Notes

Checklist

  • My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.
  • I have updated the documentation to reflect my changes.

@trunk-io
Copy link

trunk-io bot commented Jul 26, 2023

Merging to develop in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@nh916 nh916 requested a review from InnocentBug July 26, 2023 20:05
@InnocentBug
Copy link
Collaborator

is there an option to error on a warning when we build the docs?
if yes, we might want to enable that for testing.

@nh916
Copy link
Contributor Author

nh916 commented Jul 26, 2023

is there an option to error on a warning when we build the docs? if yes, we might want to enable that for testing.

yeah the option would be

mkdocs build --strict

however, when I first enabled it I was getting errors all the time and did not have time to fix them so I removed it for now. Some of the warnings that it is giving I am not sure how to fix

@InnocentBug
Copy link
Collaborator

That's fair, something to put on the post release to-do list

@nh916 nh916 merged commit 1003bb2 into develop Jul 26, 2023
14 checks passed
@nh916 nh916 deleted the docs_check.yaml-code-clean-up branch July 26, 2023 22:17
@nh916
Copy link
Contributor Author

nh916 commented Jul 26, 2023

That's fair, something to put on the post release to-do list

https://trello.com/c/al79B7wH

this can also be a github issue to let any open source developer help with the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants