Fix problems with the node cache #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚫 This pull request was closed and has been removed from the merge queue (details). |
|
@duboyal old_project_paginator = cript_api.search(node_type=cript.Project, search_mode=cript.SearchModes.UUID, value_to_search=str(new_project.uuid))
old_project_paginator.auto_load_nodes = False
old_json = next(old_project_paginator)
old_project_node, old_tree_cache = cript.load_nodes_from_json(normal_serial, _use_uuid_cache=dict())And then you can go about it as discussed. Key here is, that you override the normal UUID cache with an empty dictionary in the This should automatically correspond to what we called the |
InnocentBug
commented
Mar 12, 2024
| @@ -349,7 +350,22 @@ def load_nodes_from_json(nodes_json: Union[str, Dict]): | |||
| # but catches a lot of odd cases. And at the moment performance is not bottle necked here | |||
| if not isinstance(nodes_json, str): | |||
| nodes_json = json.dumps(nodes_json) | |||
| return json.loads(nodes_json, object_hook=node_json_hook) | |||
|
|
|||
InnocentBug
commented
Mar 12, 2024
| @@ -32,16 +29,26 @@ class JsonAttributes(BaseNode.JsonAttributes): | |||
|
|
|||
| _json_attrs: JsonAttributes = JsonAttributes() | |||
|
|
|||
| def __new__(cls, *args, **kwargs): | |||
| uuid: Optional[str] = kwargs.get("uuid") | |||
There was a problem hiding this comment.
this fixes the bug that we had before.
Fun playing with something new like the __new__
duboyal
previously approved these changes
Mar 12, 2024
duboyal
approved these changes
Mar 12, 2024
|
/trunk merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now the node UUID cache actually works as intended.
Users can only have one python object with the same UUID.
Changes
Added a functionality that allows you to circumvent this cache explictly.
This should be a feature that users don't really use.
Known Issues
Notes
Checklist
CONTRIBUTORS.md) in the pull request source branch.