chore: audit fixes — LICENSE, CI, correct repo URL, packaging hygiene - #9
Merged
Conversation
added 4 commits
August 25, 2026 12:09
- Add Apache 2.0 LICENSE file (referenced by README and setup.py but missing) - Fix setup.py url to point at CESNET repo instead of old fork - Add Python 3.14 classifier (NetBox 4.6 runs on py3.14) - Add GitHub Actions CI: ruff + pytest on Python 3.12-3.14 - Track ruff.toml; ignore build/
Triggered when a GitHub release is published: builds sdist+wheel and uploads via PyPI trusted publishing (OIDC) - no API token stored in GitHub. Requires the GitHub publisher to be configured once on pypi.org (project Publishing settings: repo CESNET/netbox-plugin-reloader, workflow publish.yml, environment pypi).
Pin ruff==0.14.4 in CI so lint results match local runs instead of drifting with each ruff release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings from an overall repo audit against NetBox plugin development best practices. No runtime code changes.
Changes
url— pointed to the old Kani999 fork; PyPI now links to the CESNET reporuff.toml— lint config was gitignored, now shared with contributors and CIbuild/— untracked noise after every buildAudit summary (clean, no action)
PluginConfig correctness, version pins, deferred imports in
ready(), logging, fault isolation, and unit tests all pass the checklist; no deprecated 4.6 APIs remain after 4.6.0.2. Deliberately skipped: pyproject.toml migration (setup.py works; YAGNI).Testing
ruff check .clean, 17/17 tests pass locally