Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pymod.find_installation() to find python in meson.build #1076

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

nshaheed
Copy link
Contributor

Since Monterey 12.3, macOS removed python2.7 from it's base installation. This means that python is not longer a command by default (just python3), and the build for CLI11 fails. This PR moves to using pymod.find_installation() to handle this in a more general way. See https://mesonbuild.com/Python-module.html

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e4ee3af) to head (c5bb943).
Report is 45 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #1076     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           17        17             
  Lines         4546      4698    +152     
  Branches         0      1007   +1007     
===========================================
+ Hits          4546      4698    +152     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phlptp
Copy link
Collaborator

phlptp commented Oct 12, 2024

I have no experience with meson, but seems reasonable.
@henryiii unless you have objections I will approve and merge on Monday.

@henryiii
Copy link
Collaborator

This looks correct to me.

@henryiii henryiii merged commit 32ea8d5 into CLIUtils:main Oct 13, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants