add optional to cpack include in cmake #900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If cpack was already include, including it again without the `optional` argument creates an error. With the following message: ``` [cmake] CMake Warning at /usr/share/cmake/Modules/CPack.cmake:507 (message): [cmake] CPack.cmake has already been included!! ``` `optional` fixes this based on this documentation. https://cmake.org/cmake/help/v3.5/command/include.html And it is compatible with the current minimal cmake version 3.5
|
this does not appear to be valid cmake. What we have done in other projects is wrap the entire CPACK section in a conditional variable, so it can be completely turned off if not needed. guessing packaging isn't done that often for CLI11 so it wouldn't affect much to have it disabled by default. |
|
The OPTIONAL is backward. And I also think it doesn't do what you want it to do - it avoids an error if it's missing, not an error if it's already been included. You probably could protect it with something that CPack defines, though. (Or disable by default is also fine). |
|
Also, is that an error or a warning? |
|
Actually, we should probably only do the CPack stuff if this is the main project. That would fix this. |
henryiii
added a commit
that referenced
this pull request
Sep 15, 2023
Alternative fix to, and closes #900. Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If cpack was already include, including it again without the
optionalargument creates an error. With the following message:optionalfixes this based on this documentation. https://cmake.org/cmake/help/v3.5/command/include.html And it is compatible with the current minimal cmake version 3.5