Multiline string config #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
|
This is necessary to fix the issue exposed by #930 |
|
The basic issue is that it is possible to get multiline strings as a value into CLI11, and if those values are made into a config string they generate config files that can't be read, and cause some very strange crossover effects and errors, so the solution is that CLI11 needs to be able to have some way to generate and support strings containing newlines. The obvious solution is to support TOML multiline strings in the config files. Which is what this PR does. |
…ing test cases update documentation style: pre-commit.ci fixes
phlptp
force-pushed
the
multiline_string_config
branch
from
a0356ad
to
36378d3
Compare
github-actions
bot
added
the
needs changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for TOML style multiline string values and comments