Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for quotes in the config naming to match TOML standard #967

Merged
merged 6 commits into from
Dec 31, 2023

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Dec 30, 2023

This PR is to further support for TOML. To allow and generate quoted names in config files including those separated by the parent separator.

like

"sub"."sub2".value=1
'sub'.'sub.sub'.value=2

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (91220ba) 100.00% compared to head (0150846) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #967   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         4492      4506   +14     
=========================================
+ Hits          4492      4506   +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phlptp phlptp requested a review from henryiii December 30, 2023 22:36
@phlptp
Copy link
Collaborator Author

phlptp commented Dec 30, 2023

2 more steps after this one. Update the value handlers to match TOML specifications and then update documentation.

@phlptp phlptp merged commit dc137f0 into CLIUtils:main Dec 31, 2023
50 checks passed
@phlptp phlptp deleted the quoted_config_names branch December 31, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant