Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop one arg parse shortcut #987

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

henryiii
Copy link
Collaborator

This removes the one arg unicode-aware non-standard shortcut.

Two more things to look at before release:

  • How does our unicode support work with wmain? That's the "correct" way to do unicode on Windows.
  • What happens if someone doesn't expect / want unicode and you prepare for unicode? Is it better or worse that if you didn't prepare for it?

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (20de8b7) 100.00% compared to head (6a62480) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #987   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        17    -1     
  Lines         4573      4546   -27     
=========================================
- Hits          4573      4546   -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii merged commit b8edd50 into main Jan 31, 2024
54 checks passed
@henryiii henryiii deleted the henryiii/fix/droponargparse branch January 31, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant