Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Commit

Permalink
BATIAI-2423-HOTFIX: resolving syntax errors (#152)
Browse files Browse the repository at this point in the history
* resolving syntax errors

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
  • Loading branch information
afaras0572 and pre-commit-ci-lite[bot] authored May 10, 2024
1 parent df4a2a0 commit 314dfb1
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 15 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

## 16.0.1
* resolving syntax errors

## 16.0.0
* upgrade to EKS module 20.8.5
* introducing eks access entries and making updates
Expand Down
20 changes: 5 additions & 15 deletions eks-access-entries.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@ resource "aws_eks_access_entry" "cluster_admin" {
type = "STANDARD"
user_name = try(each.value.user_name, null)

depends_on = [
module.eks_managed_node_groups,
]
depends_on = [module.eks_managed_node_groups]
}

resource "aws_eks_access_policy_association" "cluster_admin" {
Expand All @@ -31,9 +29,7 @@ resource "aws_eks_access_policy_association" "cluster_admin" {
policy_arn = "arn:${data.aws_partition.current.partition}:eks::aws:cluster-access-policy/AmazonEKSClusterAdminPolicy"
principal_arn = each.value

depends_on = [
aws_eks_access_entry.cluster_admin,
]
depends_on = [aws_eks_access_entry.cluster_admin]
}

## The resources access entry and policy association is targeting roles that require cluster Admin ReadOnly Permissions
Expand All @@ -46,9 +42,7 @@ resource "aws_eks_access_entry" "cluster_admin_readonly" {
type = "STANDARD"
user_name = try(each.value.user_name, null)

depends_on = [
module.eks_managed_node_groups,
]
depends_on = [module.eks_managed_node_groups]
}

resource "aws_eks_access_policy_association" "cluster_admin_readonly" {
Expand All @@ -64,9 +58,7 @@ resource "aws_eks_access_policy_association" "cluster_admin_readonly" {
policy_arn = "arn:${data.aws_partition.current.partition}:eks::aws:cluster-access-policy/AmazonEKSAdminViewPolicy"
principal_arn = each.value

depends_on = [
aws_eks_access_entry.cluster_admin_readonly,
]
depends_on = [aws_eks_access_entry.cluster_admin_readonly]
}

## Creating access entry for delete_ebs_volumes_lambda with namespaced adminpolicy
Expand Down Expand Up @@ -95,7 +87,5 @@ resource "aws_eks_access_policy_association" "delete_ebs_volume" {
policy_arn = "arn:${data.aws_partition.current.partition}:eks::aws:cluster-access-policy/AmazonEKSAdminPolicy"
principal_arn = var.delete_ebs_volume_role_arn

depends_on = [
aws_eks_access_entry.delete_ebs_volume,
]
depends_on = [aws_eks_access_entry.delete_ebs_volume]
}

0 comments on commit 314dfb1

Please sign in to comment.