This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
BATIAI-2353 eks module update #143
Merged
dahoward5
merged 37 commits into
BATSAD-2113-bottlerocket-addition
from
BATIAI-2353-EKS-module-update
Mar 27, 2024
Merged
BATIAI-2353 eks module update #143
dahoward5
merged 37 commits into
BATSAD-2113-bottlerocket-addition
from
BATIAI-2353-EKS-module-update
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snyk Scanning for Commit: d2e39b2 Snyk Infrastructure as Code
Issues Test Summary Organization: batcave-ispg ✔ Files without issues: 10 Report Complete Your test results are available at: https://snyk.io/org/batcave-ispg/projects |
bushong1
suggested changes
Mar 25, 2024
…nto BATIAI-2353-EKS-module-update # Conflicts: # variables.tf
…nto BATIAI-2353-EKS-module-update
bushong1
suggested changes
Mar 26, 2024
…nto BATIAI-2353-EKS-module-update
bushong1
reviewed
Mar 26, 2024
bushong1
reviewed
Mar 26, 2024
Co-authored-by: Charles Bushong <charles.bushong@cms.hhs.gov>
bushong1
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, great work.
Approved. Nicely done! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue: BATIAI-2353
Description: Updates to remove custom node pools and only support eks managed nodes. Make CMS AMI default with the ability to go to bottlerocket. Dynamic block device assignments based on AMI.
Security Impact Analysis Questionnaire
Submitter Checklist
Security Risks Identified - N/A