-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully implement US4, various recurring goal & testing improvements #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we should have a separate file for these time related test
we really need a label that makes tests run |
# Conflicts: # app/src/main/java/edu/ucsd/cse110/successorator/MainViewModel.java
…curring goals got deleted with not visible instances were not tested
…on generating strings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job covering the case where we try finishing a goal in tomorrow when the same goal is in the today view. Nice exhaustive tests.
Abstract
This finishes the backend for the tomorrow subsystem, and fills in the tests.
Issues
Closes #81
Type of Change
Testing
Tests were written for the tomorrow filter
Checklist
The code is understandable.
The code is well structured.
The code is correct.
Pending Items
No