Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully implement US4, various recurring goal & testing improvements #115

Merged
merged 9 commits into from
Mar 14, 2024

Conversation

otisdog8
Copy link
Contributor

Abstract

This finishes the backend for the tomorrow subsystem, and fills in the tests.

Issues

Closes #81

Type of Change

  • New feature (non-breaking change which adds functionality)

Testing

Tests were written for the tomorrow filter

Checklist

  • The code is understandable.

    • The code is follows formatting conventions (spacing, indents, etc).
    • The code makes use of names that sound like behavior.
    • The code is commented in hard-to-understand areas.
    • The code contains changes to documentation if needed.
  • The code is well structured.

    • The code is organized into logical components.
    • The components sound like the behavior (requirements) they implement.
    • The components have clearly defined single responsibilities.
  • The code is correct.

    • The changes include tests that prove the fix is effective or that the feature fully works.
    • The changes generate no new failed tests, build errors, or warnings.

Pending Items

No

Copy link
Contributor

@ZenoCS-Git ZenoCS-Git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should have a separate file for these time related test

@otisdog8 otisdog8 closed this Mar 14, 2024
@otisdog8
Copy link
Contributor Author

we really need a label that makes tests run

@otisdog8 otisdog8 reopened this Mar 14, 2024
@otisdog8 otisdog8 changed the title Fully propagate tomorrow state changes, test tomorrow components Fully implement US4, various recurring goal & testing improvements Mar 14, 2024
Copy link
Contributor

@emguz emguz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job covering the case where we try finishing a goal in tomorrow when the same goal is in the today view. Nice exhaustive tests.

@emguz emguz merged commit 2779cf0 into master Mar 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.1 Data model changes to support internal “time” offset deps on 1.1
3 participants