-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Bug Fixes + Goal Creation Functionality #117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenoCS-Git
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job with user input validation for Recurring Goals
Bug fix commit is redundant, rolling back. Otherwise, lgtm |
wizard1238
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Fixed a big that showed recurring goal creation menu in the pending goal listview
Added a Date string UI on recurring goals in the recurring goal listview
Added functionality of recurring goals made in Today and Tomorrow list should show in the recurring page
Issues
Fixes #66
Fixes #67
Closes #85
Closes #86
Type of Change
Testing
Performed manual testing on UI features as well as wrote test for Date string UI.
Checklist
Perform a self-review using the following checklist. Some items may not apply to your PR if it
is for a bug fix. You can check an item by replacing the [ ] with [x].
The code is understandable.
The code is well structured.
The code is correct.
Pending Items
Is there anything else that needs to be done before this PR can be merged?
None