Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Bug Fixes + Goal Creation Functionality #117

Merged
merged 13 commits into from
Mar 15, 2024
Merged

Conversation

JGonzaga7
Copy link
Contributor

@JGonzaga7 JGonzaga7 commented Mar 14, 2024

Abstract

Fixed a big that showed recurring goal creation menu in the pending goal listview
Added a Date string UI on recurring goals in the recurring goal listview
Added functionality of recurring goals made in Today and Tomorrow list should show in the recurring page

Issues

Fixes #66
Fixes #67
Closes #85
Closes #86

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)

Testing

Performed manual testing on UI features as well as wrote test for Date string UI.

Checklist

Perform a self-review using the following checklist. Some items may not apply to your PR if it
is for a bug fix. You can check an item by replacing the [ ] with [x].

  • The code is understandable.

    • The code is follows formatting conventions (spacing, indents, etc).
    • The code makes use of names that sound like behavior.
    • The code is commented in hard-to-understand areas.
    • The code contains changes to documentation if needed.
  • The code is well structured.

    • The code is organized into logical components.
    • The components sound like the behavior (requirements) they implement.
    • The components have clearly defined single responsibilities.
  • The code is correct.

    • The changes include tests that prove the fix is effective or that the feature fully works.
    • The changes generate no new failed tests, build errors, or warnings.

Pending Items

Is there anything else that needs to be done before this PR can be merged?
None

Copy link
Contributor

@ZenoCS-Git ZenoCS-Git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with user input validation for Recurring Goals

@JGonzaga7 JGonzaga7 changed the title UI Bug Fixes UI Bug Fixes + Goal Creation Functionality Mar 14, 2024
@wizard1238
Copy link
Contributor

Bug fix commit is redundant, rolling back. Otherwise, lgtm

@wizard1238 wizard1238 self-assigned this Mar 15, 2024
Copy link
Contributor

@wizard1238 wizard1238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wizard1238 wizard1238 merged commit 048117e into master Mar 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants