Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readd mock #122

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Readd mock #122

merged 2 commits into from
Mar 15, 2024

Conversation

erichu100
Copy link
Contributor

Abstract

Readded mock time button
Moved focus mode menu to right
Focus mode now changes top bar instead of menu highlight.

Issues

Type of Change

  • New feature (Re-added mock time)
  • New feature (change action bar color)

Testing

Manual testing since just UI changes.

Checklist

Perform a self-review using the following checklist. Some items may not apply to your PR if it
is for a bug fix. You can check an item by replacing the [ ] with [x].

  • The code is understandable.

    • The code is follows formatting conventions (spacing, indents, etc).
    • The code makes use of names that sound like behavior.
    • The code is commented in hard-to-understand areas.
    • The code contains changes to documentation if needed.
  • The code is well structured.

    • The code is organized into logical components.
    • The components sound like the behavior (requirements) they implement.
    • The components have clearly defined single responsibilities.
  • The code is correct.

    • The changes include tests that prove the fix is effective or that the feature fully works.
    • The changes generate no new failed tests, build errors, or warnings.

Pending Items

asdfgasdvgasfloyuiawh

Copy link
Contributor

@ZenoCS-Git ZenoCS-Git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI might be a little cramp but will work out

Copy link
Contributor

@otisdog8 otisdog8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately putting the hamburger button on the left would be 1. dubious and 2. require >100loc. Good solution and looks nice

@otisdog8 otisdog8 merged commit a54e193 into master Mar 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants