-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a rule to detect LTR properties #533
base: master
Are you sure you want to change the base?
Conversation
Do you hand roll LTR files or generate them with something like CSSJanus? On Fri, Aug 1, 2014 at 5:55 AM, Lewis Nyman notifications@github.com
|
We used to hand roll separate files, which was a maintenance nightmare. Now we've switched to using [dir="rtl"] selectors directly after the LTR CSS in Drupal 8. I've never seen CSSJanus before, interesting! I'll ask around if it's been tried previously. |
I had a lot of fun working on this rule, the test process is great! I don't know if this rule should be added to csslint or if it's applicable to everyone, but it would be nice to get some feedback. |
@lewisnyman BTW, there is also a php version of cssjanus. We use it in MediaWiki and it really saves you a ton of trouble. |
clear: { | ||
left: 1, | ||
right: 1, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the trailing comma.
Drupal has a requirement to support RTL languages, this is a lot of work to achieve and often slips through our review process. I want to make csslint a formal part of our review process and having a rule that detects LTR specific properties would be a great help.
I've opened the equivalent issue to track this on Drupal.org here:
https://www.drupal.org/node/2313783