Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic classes are not overqualified #613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ovanderzee
Copy link

Frameworks like angular-js create dynamic classes like ng-hide that might require styling other than the styles from the frameworks stylesheet. Since the framework style sheet is not linted the combination ".ng-hide {...} a.ng-hide {...}" is not excluded from a warning.

This request will prevent unsound recommendations like: "WARNING: Element (li.ng-leave) is overqualified, just use .ng-leave without element name...".

…ecify in addition to the unseen styles of the framework
@frvge
Copy link
Contributor

frvge commented Jan 10, 2016

I don't think hardcoding the Angular prefixes like this is the way to go. Maybe an array property for excluded prefixes + a loop would work?

Can you give an example of when the .ng-hide would need adjusting on an element level? I would expect that if you want to add custom styling, that you'd add an extra class in Angular.

Also please rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants