-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON formatter #642
base: master
Are you sure you want to change the base?
Add JSON formatter #642
Conversation
503b16a
to
ba8984b
Compare
Not sure if this implementation is correct, considering that formatResults() returns nothing and all work is done in endFormat(). This works, but feels bad and some users of CSSLint call formatResults directly. Not sure how to do this better considering that output from multiple files is simply concatenated and wrapped with startFormat() and endFormat() - this doesn't work for JSON, obviously as it requires commas between results. |
Duplicate of #606, but I'd be happy if either of our PR's get accepted... |
This doesn't take into account the |
@Arcanemagus I can try merging the two implementations. |
Anyone has any idea why travis-ci build is failing? from the logs it doesn't seem like there are any issues with the code, just some permissions issues with the build script. |
Updated #606 with proper support for multiple files, mind looking over it and making sure I'm not missing anything? |
Re-ran the tests now that it's Node 5.7.1 |
@frvge thank you, I was wondering if it's my code breaking something I don't understand. |
@sergeychernyshev , we've merged #606. Is your version still needed? |
JSON formatter for CSSLint results