fix: 릴리즈 리뷰 반영 — 인기 검색어 trend 비교 소문자 키 - #256
Conversation
GROUP BY는 collation(ci)으로 묶여 스냅샷마다 대표 표기가 다를 수 있는데('3d' ↔ '3D')
JS Map 비교는 대소문자를 구분해 같은 검색어가 NEW로 오판됨. 직전 순위 맵을 소문자
키로 만들어 비교한다. 회귀 테스트 1건('3D' → '3d' 표기 변화 시 NEW가 아니라 DOWN).
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🩺 NestJS Doctor — 90/100 (Excellent)진단 288건 (error 0).
architecture / security 상위 항목
|
🧹 knip — dead-code 리포트전체 리포트
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da14ea74eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // 아니지만 실사용 대표 케이스). | ||
| const previousRankByKeyword = new Map( | ||
| previous.map((row) => [row.keyword, row.rank]), | ||
| previous.map((row) => [row.keyword.toLowerCase(), row.rank]), |
There was a problem hiding this comment.
Match the database collation instead of only lowercasing
When a keyword changes between collation-equivalent Unicode forms that lowercasing does not canonicalize—for example, a previous İ and current i under the configured utf8mb4_unicode_ci collation—MySQL may group them as the same keyword, but these calls produce distinct i\u0307 and i Map keys. The current item is consequently still reported as NEW; use comparison semantics equivalent to the database collation or persist a stable normalized aggregation key.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
미반영(문서화된 트레이드오프): 커밋·주석에 "collation 완전 동치는 아니지만 실사용 대표 케이스(대소문자)" 명시. 한국어 케이크 검색 도메인에서 İ/i̇ 류 유니코드 동치 케이스는 실효성이 없고, 완전 동치는 집계 시 정규화 키 컬럼 영속화가 필요한 별도 과제. 오판 결과도 trend 표기(NEW vs UP)의 시각적 차이에 그침.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Coverage report
Test suite run success1773 tests passing in 207 suites. Report generated by 🧪jest coverage report action from da14ea7 |
릴리즈 PR #255 Codex 지적 반영. GROUP BY collation(ci) 대표 표기가 스냅샷마다 달라질 수 있어('3d'↔'3D') trend 비교가 NEW로 오판되는 문제 — 직전 순위 맵을 소문자 키로 비교. 회귀 테스트 1건.