Skip to content

Harden authentication and session audit ingestion - #68

Open
somethingwithproof wants to merge 7 commits into
Cacti:developfrom
somethingwithproof:fix/auth-session-audit-review
Open

Harden authentication and session audit ingestion#68
somethingwithproof wants to merge 7 commits into
Cacti:developfrom
somethingwithproof:fix/auth-session-audit-review

Conversation

@somethingwithproof

@somethingwithproof somethingwithproof commented Aug 29, 2026

Copy link
Copy Markdown
Member

Summary

  • Supersedes conflicted PR Feature/auth session audit #64 with its original commits rebased onto the current develop branch.
  • Captures authentication, authorization-denied, and completed-logout events using native Cacti plugin APIs.
  • Adds fail-closed durable user_log ingestion with deterministic event identity, bounded retries, terminal dropped-row evidence, and database-clock activation.
  • Makes authentication auditing opt-in and requires explicit admin CLI setup for local user_log indexes.
  • Adds replay-safe, rate-proportional marker cleanup and idempotent external-file delivery.
  • Protects the audit master switch, retention, external-file, authentication, and Syslog settings with Audit Log Admin.
  • Bumps the plugin to 1.6 and removes obsolete compatibility helpers in favor of PHP 8.1+ idioms.

Validation

  • Authentication/session executable-line coverage: 100% (343/343).
  • Security, controller, Syslog queue, setup-default, and index-ownership tests pass.
  • PHP syntax, PHP-CS-Fixer, and actionlint pass.
  • Real-MySQL integration runs in the full Cacti CI workflow, including user_log timestamp and primary-key contract checks.
  • Mandatory pre-push critical/high/medium review: PASS with no missing tests.

Operator note

Before enabling authentication auditing, run php plugins/audit/audit_auth_indexes.php. This keeps core-table DDL out of checkbox and poller paths.

bmfmancini and others added 7 commits August 28, 2026 02:26
- ingest Cacti user_log events with transactional deduplication
- capture logout completion and authorization-denied events
- add brute-force detection with atomic alert throttling
- preserve deduplication state across audit-log purges
- add authentication settings and upgrade handling
- test Cacti 1.2.x and develop compatibility in CI
- add behavioral coverage for races, retries, paging, and retention
And fix bruteforce detection settings
@somethingwithproof
somethingwithproof force-pushed the fix/auth-session-audit-review branch from 2653946 to f14b9bb Compare August 29, 2026 05:33
@somethingwithproof
somethingwithproof marked this pull request as ready for review August 29, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants