Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: OpenHarvest-13 prepare backend for production with integrations confi… #14

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vikasjagtap
Copy link
Collaborator

…gurable per organisation

@vikasjagtap vikasjagtap requested a review from rayoz12 May 15, 2022 11:42
@@ -15,7 +15,7 @@ export default function Nav() {

return (
// @ts-ignore
<Header aria-label="IBM Platform Name">
<Header aria-label="Open Harvest">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently we're cool enough to have it be one complete word now. Which I think what the brand is. I think one of Daniel's later commits address it. So you'll have to rebase to get those changes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, I saw it, I will change it. Yes! We are cool 😎

Copy link
Collaborator

@rayoz12 rayoz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Vikas Jagtap added 2 commits May 17, 2022 21:32
# Conflicts:
#	backend/src/integrations/EIS/EIS-api.service.ts
#	backend/src/main.ts
#	react-app/src/App.tsx
#	react-app/src/components/Nav/Nav.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants