Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(canner): implement new data source canner #823

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

grieve54706
Copy link
Contributor

@grieve54706 grieve54706 commented Oct 14, 2024

Summary

Support new data source Canner Enterprise. It provides the PG wire protocol, so we can connect it by following Postgres.

Connection info

  • host: str
  • port: str
  • user: str
  • pat: str
  • workspace: str
  • enable_ssl: bool, If true, will connect with HTTPS

Additional information

  • Canner enterprise does not support CREATE TEMPORARY VIEW to get the schema for ibis. We need to build schema by dry-run.
  • Canner enterprise does not support dry-run, so we have to query with a limit of zero
  • The table and column comments are stored in another service of Canner Enterprise. We need to query them by GraphQL.
  • Preparing Canner Enterprise to test is difficult, so we don't test this feature in the CI.

@grieve54706 grieve54706 requested review from goldmedal and removed request for goldmedal October 14, 2024 06:11
@grieve54706 grieve54706 marked this pull request as ready for review October 16, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant