Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fine-grained tests for herg QC #23

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fine-grained tests for herg QC #23

wants to merge 10 commits into from

Conversation

kwabenantim
Copy link
Member

@kwabenantim kwabenantim commented Aug 8, 2024 •
edited
Loading

Description

Supports #21

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

Documentation checklist

  • I have updated all documentation in the code where necessary.
  • I have checked spelling in all (new) comments and documentation.
  • I have added a note to RELEASE.md if relevant (new feature, breaking change, or notable bug fix).

@kwabenantim kwabenantim self-assigned this Aug 8, 2024
@kwabenantim kwabenantim added the enhancement New feature or request label Aug 8, 2024
@kwabenantim kwabenantim linked an issue Aug 8, 2024 that may be closed by this pull request
Lower level unit tests for every QC criterion #21
Open
@kwabenantim kwabenantim marked this pull request as ready for review August 12, 2024 13:43
@kwabenantim kwabenantim changed the title Fine-grained tests for herg QC Fine-grained test outputs for herg QC Aug 12, 2024
@kwabenantim kwabenantim changed the title Fine-grained test outputs for herg QC Fine-grained tests for herg QC Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kwabenantim kwabenantim

@frankiepe frankiepe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lower level unit tests for every QC criterion
2 participants
@kwabenantim @frankiepe