perf: don't update all lines before adding a viewer

CatCoderr · Jun 27, 2023 · 40ed0a2 · 40ed0a2
1 parent 85c2d5d
commit 40ed0a2
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/README.md b/README.md
@@ -105,7 +105,7 @@ sidebar.addLine(
     Component.text("Just a static line").color(NamedTextColor.GREEN));
 // add an empty line
 sidebar.addBlankLine();
-// also you can add updatable lines which applies to all players
+// also you can add updatable lines which applies to all players receiving this sidebar
 sidebar.addUpdatableLine(
     player -> Component.text("Your Hunger: ")
         .append(Component.text(player.getFoodLevel())

diff --git a/src/main/java/me/catcoder/sidebar/Sidebar.java b/src/main/java/me/catcoder/sidebar/Sidebar.java
@@ -392,8 +392,6 @@ public void destroy() {
     @SneakyThrows
     public void addViewer(@NonNull Player player) {
         if (!viewers.contains(player.getUniqueId())) {
-            updateAllLines();
-
             objective.create(player);
 
             for (SidebarLine<R> line : lines) {
@@ -421,8 +419,6 @@ public void removeViewer(@NonNull Player player) {
     }
 
     private void removeViewer0(@NonNull Player player) {
-        updateAllLines();
-
         lines.forEach(line -> line.removeTeam(player, objective.getName()));
         objective.remove(player);
     }