Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Travis to GitHub Actions #730

Merged
merged 17 commits into from
Sep 29, 2023
Merged

Switch from Travis to GitHub Actions #730

merged 17 commits into from
Sep 29, 2023

Conversation

kring
Copy link
Member

@kring kring commented Sep 20, 2023

No description provided.

Copy link
Contributor

@csciguy8 csciguy8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like equivalent changes to travis, with some improvements. I'm excited to use it.

Just some assorted questions due to my own ignorance. Looks good to go though.

@csciguy8
Copy link
Contributor

One more observation. All the jobs are slower than their equivalent travis jobs. All but the macOS build are ~2x slower. Even with this, the times still seem reasonable.

@kring
Copy link
Member Author

kring commented Sep 29, 2023

All but the macOS build are ~2x slower.

I'm guessing this is because we're building/testing the release configuration, too, now. If the extra build time is a problem, we could separate the debug and release configurations into separate jobs. Or even remove the release build entirely, to go back to the way things were on Travis.

@kring
Copy link
Member Author

kring commented Sep 29, 2023

This is ready for another look.

@csciguy8
Copy link
Contributor

All but the macOS build are ~2x slower.

I'm guessing this is because we're building/testing the release configuration, too, now. If the extra build time is a problem, we could separate the debug and release configurations into separate jobs. Or even remove the release build entirely, to go back to the way things were on Travis.

Makes sense. More work, more time needed.

I like the idea of catching release build problems, release test problems. Sounds worth it to me.

@csciguy8 csciguy8 self-requested a review September 29, 2023 03:23
@csciguy8
Copy link
Contributor

Weird, looks like the latest Linux + Clang build is failing.

I don't see any commits that could have broken it since the last good build, but I do see that the runner image version has changed (now 20230924.1.0)

image

@kring
Copy link
Member Author

kring commented Sep 29, 2023

looks like the latest Linux + Clang build is failing.

Ha yeah apparently GitHub just removed Clang 12 support from their Linux runner:
actions/runner-images#8263

Should be able to switch to ubuntu-20.04. I'll try it.

So that we can use Clang 12.
@csciguy8 csciguy8 removed their request for review September 29, 2023 17:35
@csciguy8 csciguy8 merged commit 55b3083 into main Sep 29, 2023
28 checks passed
@csciguy8 csciguy8 deleted the github-actions branch September 29, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants