Improvements to the build process #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use `ktx` library instead of `ktx_read`. The former includes writing ability, and there's no library that includes _just_ writing. * Move STB image resize implementation code into CesiumGltfReader (instead of CesiumGltfContent).
Mostly so that KTX-Software doesn't try to pull in cxxopts.
Does this fix #813? |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ktxlibrary instead ofktx_read. While cesium-native currently only needs the read functionality, by depending onktx_readcesium-native prevents anything that uses cesium-native from bringing in the write functionality. This is because there's noktx_write. The only options arektx_readwhich is read-only, andktxwhich includes both. If you try to link against bothktxandktx_read, you'll end up with multiply-defined symbols.CesiumGltfReaderwould get linker errors.KTX_FEATURE_TOOLSto off. This saves a bit of time, and also stops KTX from bringing in its only implementation of cxxopts.