Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EXT_accessor_additional_types #968

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

lilleyse
Copy link
Contributor

EXT_accessor_additional_types defines additional accessor component types INT, INT64, UNSIGNED_INT64, and DOUBLE.

We're using this branch for some internal pipelines where it's helpful to have higher precision types when manipulating glTF data. The changes really only matter when constructing AccessorViews directly and shouldn't affect the runtimes.

The extension also defines HALF_FLOAT but since std::float16_t is only available in C++23 it's not included here.

@javagl
Copy link
Contributor

javagl commented Oct 23, 2024

My gut feeling is that the spin-off extension at KhronosGroup/glTF#2397 is more likely to become "official" - exactly because it is more fine-grained and avoids the potential hassle of "half" often not being present.

But on the level of the implementation, this should be a true subset of what is now supported here (so... this comment may just be nitpicking/noise 😶 )

@kring
Copy link
Member

kring commented Nov 5, 2024

Thanks @lilleyse!

@kring kring merged commit be7cfe2 into main Nov 5, 2024
24 checks passed
@kring kring deleted the additional-component-types branch November 5, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants