Skip to content

Commit

Permalink
Clean up CesiumTextureUtility
Browse files Browse the repository at this point in the history
  • Loading branch information
azrogers committed Oct 10, 2024
1 parent 9a675e2 commit 85d6b39
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
1 change: 0 additions & 1 deletion Source/CesiumRuntime/Private/CesiumTextureUtility.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,6 @@ bool getUseMipmapsIfAvailableFromSampler(const CesiumGltf::Sampler& sampler) {
case CesiumGltf::Sampler::MinFilter::NEAREST_MIPMAP_LINEAR:
case CesiumGltf::Sampler::MinFilter::NEAREST_MIPMAP_NEAREST:
return true;
break;
default: // LINEAR and NEAREST
return false;
}
Expand Down
8 changes: 1 addition & 7 deletions Source/CesiumRuntime/Private/CesiumTextureUtility.h
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,6 @@ struct LoadedTextureResult {
* associated Unreal texture.
* @param sRGB True if the texture should be treated as sRGB; false if it should
* be treated as linear.
* @param textureResources Unreal RHI texture resources that have already been
* created for this model. This array must have the same size as `model`'s
* {@link CesiumGltf::Model::images}, and all pointers must be initialized to
* nullptr before the first call to `loadTextureFromModelAnyThreadPart` during
* the glTF load process.
Expand All @@ -112,10 +110,6 @@ TUniquePtr<LoadedTextureResult> loadTextureFromModelAnyThreadPart(
* @param sampler The sampler settings to use with the texture.
* @param sRGB True if the texture should be treated as sRGB; false if it should
* be treated as linear.
* @param pExistingImageResource An existing RHI texture resource that has been
* created for this image, or nullptr if one hasn't been created yet. When this
* parameter is not nullptr, the provided image's `pixelData` is not required
* and can be empty.
*/
TUniquePtr<LoadedTextureResult> loadTextureFromImageAndSamplerAnyThreadPart(
CesiumGltf::ImageAsset& image,
Expand All @@ -129,7 +123,7 @@ TUniquePtr<LoadedTextureResult> loadTextureFromImageAndSamplerAnyThreadPart(
* for {@link ExtensionImageAssetUnreal::getFuture} to resolve. This method
* should be called in a background thread.
*
* @param imageCesium The image.
* @param image The image.
* @param addressX The X addressing mode.
* @param addressY The Y addressing mode.
* @param filter The sampler filtering to use for this texture.
Expand Down

0 comments on commit 85d6b39

Please sign in to comment.