-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let AGlobeAwareDefaultPawn
use SimplePlanarEllipsoidCurve
, add more tests
#1348
Conversation
These tests look a lot like the tests in CesiumGS/cesium-native#797. What do you think about not bothering with the new Unreal tests, but just integrating with the native implementation, thus relying on the native tests instead? (that said, Unreal side tests do have value, but I have a feeling most of the corner cases are in path calculation) |
My fault for not reading the issue closely when I passed this to @azrogers. @csciguy8 was there anything else you were thinking of testing when you wrote up the issue? One thing I could think of is testing that it adjusts its orientation as it moves across the Earth. Regarding the fly-to behavior, though, perhaps we can simplify the tests just to "make sure it works" without going to deeply into the math? |
I like that, a test for orientation sounds reasonable. And maybe a test to make sure the flight path doesn't fly through the earth? (height stays >0). As far as what goes into the Unreal side, maybe we can just check that we can start at X and arrive at Y when we expect? (verifying the integration code). All the subtleties in the middle can be a cesium-native test. Open to discussion though. Just trying to avoid too much duplication and test coverage that won't really help us in the end. |
@csciguy8 Implemented |
AGlobeAwareDefaultPawn
AGlobeAwareDefaultPawn
use SimplePlanarEllipsoidCurve
, add more tests
Modified the title. We're doing a bit more than just adding tests :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks @azrogers .
Reviewed the code with the new SimplePlanarEllipsoidCurve integration and tested.
Will merge once CI finishes...
Fixes #1122.
Currently,
AGlobeAwareDefaultPawn
only has a single test for a bug previously encountered. This change adds more tests that check its fly-to functionality.