Add forEachRenderableTile
#1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot that only Unreal 5.4 is on C++ 20 🤦 I'll add overloads for the time being. |
#1447 moves all UE versions to C++20. |
|
Merged with main. This is ready for a look! |
|
Thanks @j9liu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
Cesium3DTileset.cpphas a lot of duplication when iterating over tiles withUCesiumGltfComponent. So, for convenience / reusability, I added aforEachRenderableTiletemplate function that allows for a callback on eachUCesiumGltfComponentin a collection of tiles.I've updated a handful of functions to use this call. It can also be reused if we ever need to collectively transform / iterate over tiles in future functionality. I haven't noticed any clear performance differences, but let me know if something here is in bad form.