Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle SampleHeightMostDetailed on tilesets that completely fail to load, and add a test. #1526

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Handle SampleHeightMostDetailed on tilesets that completely fail to load, and add a test. #1526

merged 5 commits into from
Sep 30, 2024

Conversation

kring
Copy link
Member

@kring kring commented Sep 27, 2024 •
edited
Loading

This depends on CesiumGS/cesium-native#952 so merge that first.

@kring kring mentioned this pull request Sep 28, 2024
Merged
@kring kring added this to the October 2024 Release milestone Sep 28, 2024
j9liu
j9liu reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@j9liu j9liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kring ! I confirmed that this makes the future complete, and that I'm able to print out the warning on the screen. I just had one question but if it's not an actual issue, this can be merged.

Source/CesiumRuntime/Private/Cesium3DTileset.cpp Outdated Show resolved Hide resolved
@j9liu j9liu mentioned this pull request Sep 30, 2024
Merged
@kring kring merged commit 57fa73d into main Sep 30, 2024
20 of 21 checks passed
@kring kring deleted the terrain-query-test branch September 30, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j9liu j9liu j9liu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
October 2024 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@kring @j9liu